Fix fullscreen scroll lock for hide scroll details setting#4148
Open
RobinWitch wants to merge 2 commits into
Open
Fix fullscreen scroll lock for hide scroll details setting#4148RobinWitch wants to merge 2 commits into
RobinWitch wants to merge 2 commits into
Conversation
ImprovedTube2
added
the
untested
Author
|
Reran automated validation on the current PR head (
I have not done manual browser/YouTube variant testing yet, so this only covers the repo's automated checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4129.\n\n## Summary\n- Reuse the existing hide scroll-for-details setting to lock scrolling while YouTube is in fullscreen/fake-fullscreen mode.\n- Scope the lock to YouTube fullscreen state selectors so normal video pages remain scrollable.\n- Rename the English setting label to reflect the broader behavior.\n\n## Verification\n- npm test -- --runInBand\n- npm run lint